ruanwenjun commented on code in PR #15985:
URL: 
https://github.com/apache/dolphinscheduler/pull/15985#discussion_r1597549410


##########
dolphinscheduler-master/src/main/resources/application.yaml:
##########
@@ -84,6 +84,8 @@ registry:
 master:
   listen-port: 5678
   # master prepare execute thread number to limit handle commands in parallel
+  quartz-enabled: true

Review Comment:
   And the comment is incorrect.



##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java:
##########
@@ -120,7 +124,7 @@ public void run() throws SchedulerException {
         this.eventExecuteService.start();
         this.failoverExecuteThread.start();
 
-        this.schedulerApi.start();
+        if (masterConfig.isQuartzEnabled()) this.schedulerApi.start();

Review Comment:
   ```suggestion
           if (masterConfig.isQuartzEnabled()) {
               this.schedulerApi.start();
            }
   ```



##########
dolphinscheduler-master/src/main/resources/application.yaml:
##########
@@ -84,6 +84,8 @@ registry:
 master:
   listen-port: 5678
   # master prepare execute thread number to limit handle commands in parallel
+  quartz-enabled: true

Review Comment:
   ```suggestion
     scheduler-enabled: true
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to