rickchengx commented on code in PR #15985:
URL: 
https://github.com/apache/dolphinscheduler/pull/15985#discussion_r1600992592


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java:
##########
@@ -120,7 +124,9 @@ public void run() throws SchedulerException {
         this.eventExecuteService.start();
         this.failoverExecuteThread.start();
 
-        this.schedulerApi.start();
+        if (masterConfig.isSchedulerEnabled()) {

Review Comment:
   Every time this config is modified, the master needs to be restarted. I 
don't quite understand under what circumstances the master's scheduling needs 
to be turned off, and whether this will cause other potential problems.
   
   Would you please describe more about the usage scenarios of this config?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to