pegasas commented on code in PR #15922: URL: https://github.com/apache/dolphinscheduler/pull/15922#discussion_r1602764755
########## deploy/kubernetes/dolphinscheduler/values.yaml: ########## @@ -129,6 +129,17 @@ externalDatabase: # -- The driverClassName of external database driverClassName: "org.postgresql.Driver" +datasource: + profile: postgresql + config: + driver-class-name: org.postgresql.Driver + url: jdbc:postgresql://127.0.0.1:5432/dolphinscheduler + username: root + password: root + hikari: + connection-test-query: select 1 + pool-name: DolphinScheduler Review Comment: > Got it. If you want to do this step by step, I suggest you in this PR, just define new configMap and do not modify `values.yaml`. In future PR, replace old db/registry config with new db/registry all together. > > From my perspective, this way is clearer :D Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
