Radeity commented on code in PR #15922: URL: https://github.com/apache/dolphinscheduler/pull/15922#discussion_r1584699781
########## deploy/kubernetes/dolphinscheduler/values.yaml: ########## @@ -129,6 +129,17 @@ externalDatabase: # -- The driverClassName of external database driverClassName: "org.postgresql.Driver" +datasource: + profile: postgresql + config: + driver-class-name: org.postgresql.Driver + url: jdbc:postgresql://127.0.0.1:5432/dolphinscheduler + username: root + password: root + hikari: + connection-test-query: select 1 + pool-name: DolphinScheduler Review Comment: It's incompatible with old db config, cuz ENV has higher priority. Additionally, I recommend that `enable` option for different datasource should be provided here like before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
