SbloodyS commented on code in PR #16413:
URL:
https://github.com/apache/dolphinscheduler/pull/16413#discussion_r1703445499
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParameters.java:
##########
@@ -17,47 +17,37 @@
package org.apache.dolphinscheduler.plugin.task.http;
-import org.apache.dolphinscheduler.plugin.task.api.model.ResourceInfo;
import
org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters;
import org.apache.commons.lang3.StringUtils;
-import java.util.ArrayList;
import java.util.List;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+
/**
* http parameter
*/
+@EqualsAndHashCode(callSuper = true)
+@Data
public class HttpParameters extends AbstractParameters {
- /**
- * url
- */
private String url;
- /**
- * httpMethod
- */
- private HttpMethod httpMethod;
+ @JsonProperty("httpMethod")
+ private HttpRequestMethod httpRequestMethod;
- /**
- * http params
- */
- private List<HttpProperty> httpParams;
+ @JsonProperty("httpParams")
+ private List<HttpProperty> httpRequestParams;
Review Comment:
Yes, but I think a more specific name would be better understood. WDYT?
@caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
