SbloodyS commented on code in PR #16413:
URL:
https://github.com/apache/dolphinscheduler/pull/16413#discussion_r1703493608
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParameters.java:
##########
@@ -66,83 +56,10 @@ public class HttpParameters extends AbstractParameters {
*/
private int connectTimeout;
- /**
- * Socket Timeout
- * Unit: ms
- */
- private int socketTimeout;
-
@Override
public boolean checkParameters() {
- return StringUtils.isNotEmpty(url);
- }
-
- @Override
- public List<ResourceInfo> getResourceFilesList() {
- return new ArrayList<>();
- }
-
- public String getUrl() {
- return url;
- }
-
- public void setUrl(String url) {
- this.url = url;
- }
-
- public HttpMethod getHttpMethod() {
- return httpMethod;
- }
-
- public void setHttpMethod(HttpMethod httpMethod) {
- this.httpMethod = httpMethod;
- }
-
- public List<HttpProperty> getHttpParams() {
- return httpParams;
- }
-
- public void setHttpParams(List<HttpProperty> httpParams) {
- this.httpParams = httpParams;
- }
-
- public HttpCheckCondition getHttpCheckCondition() {
- return httpCheckCondition;
- }
-
- public void setHttpCheckCondition(HttpCheckCondition httpCheckCondition) {
- this.httpCheckCondition = httpCheckCondition;
- }
-
- public String getCondition() {
- return condition;
+ return StringUtils.isNotEmpty(url) && httpRequestMethod != null
+ && connectTimeout > 0;
Review Comment:
If the user does not use the web-ui, but uses the api to make parameter
calls, there may be an exception here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
