ruanwenjun commented on code in PR #16327:
URL:
https://github.com/apache/dolphinscheduler/pull/16327#discussion_r1729060926
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/MasterSlotManager.java:
##########
@@ -89,13 +89,19 @@ public void doReBalance(List<MasterServerMetadata>
normalMasterServers) {
}
if (tmpCurrentSlot == -1) {
log.warn(
- "Do re balance failed, cannot found the current master: {}
in the normal master clusters: {}. Please check the current master server
status",
+ "Do rebalance failed, cannot found the current master: {}
in the normal master clusters: {}. Please check the current master server
status",
masterConfig.getMasterAddress(), normalMasterServers);
currentSlot = -1;
return;
}
+ if (totalSlots == normalMasterServers.size() && currentSlot ==
tmpCurrentSlot) {
+ log.debug("No need to rebalance, the currentSlot: {}, totalSlots:
{} doesn't changed", currentSlot,
+ totalSlots);
+ return;
+ }
totalSlots = normalMasterServers.size();
currentSlot = tmpCurrentSlot;
+ log.info("DO rebalance success, current master slot: {}, total master
slots: {}", currentSlot, totalSlots);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
