ruanwenjun commented on code in PR #16327:
URL:
https://github.com/apache/dolphinscheduler/pull/16327#discussion_r1729064336
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/TaskGroupCoordinator.java:
##########
@@ -421,8 +421,11 @@ public boolean needToReleaseTaskGroupSlot(TaskInstance
taskInstance) {
* @throws IllegalArgumentException If the taskInstance is null or the
task doesn't use task group.
*/
public void releaseTaskGroupSlot(TaskInstance taskInstance) {
- if (taskInstance == null || taskInstance.getTaskGroupId() <= 0) {
- throw new IllegalArgumentException("The current TaskInstance does
not use task group");
+ if (taskInstance == null) {
+ throw new IllegalArgumentException("The TaskInstance is null");
+ }
+ if (taskInstance.getTaskGroupId() <= 0) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
