ruanwenjun commented on code in PR #16565: URL: https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1740872405
########## dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/src/test/resources/logback.xml: ########## @@ -0,0 +1,21 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: Why add this file? ########## dolphinscheduler-common/src/main/resources/common.properties: ########## @@ -73,6 +73,16 @@ resource.huawei.cloud.obs.bucket.name=dolphinscheduler resource.huawei.cloud.obs.endpoint=obs.cn-southwest-2.huaweicloud.com +# tencent cloud access key id, required if you set resource.storage.type=COS +resource.tencent.cloud.access.key.id=<your-access-key-id> +# access key secret, required if you set resource.storage.type=COS +resource.tencent.cloud.access.key.secret=<your-access-key-secret> +# cos bucket name, required if you set resource.storage.type=COS +resource.tencent.cloud.cos.bucket.name=dolphinscheduler +# cos bucket region, required if you set resource.storage.type=COS, see: https://cloud.tencent.com/document/product/436/6224 +resource.tencent.cloud.cos.region=ap-nanjing Review Comment: Can we add a cos.yaml to storage the config? We don't want to continue add new config in this file, ########## dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java: ########## @@ -389,6 +389,12 @@ private TaskConstants() { public static final String HUAWEI_CLOUD_ACCESS_KEY_ID = "resource.huawei.cloud.access.key.id"; public static final String HUAWEI_CLOUD_ACCESS_KEY_SECRET = "resource.huawei.cloud.access.key.secret"; + /** + * tencent cloud config + */ + public static final String TENCENT_CLOUD_ACCESS_KEY_ID = "resource.tencent.cloud.access.key.id"; + public static final String TENCENT_CLOUD_ACCESS_KEY_SECRET = "resource.tencent.cloud.access.key.secret"; + Review Comment: Move to storage plugin module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
