Mighten commented on code in PR #16565:
URL:
https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1756751167
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java:
##########
@@ -389,6 +389,12 @@ private TaskConstants() {
public static final String HUAWEI_CLOUD_ACCESS_KEY_ID =
"resource.huawei.cloud.access.key.id";
public static final String HUAWEI_CLOUD_ACCESS_KEY_SECRET =
"resource.huawei.cloud.access.key.secret";
+ /**
+ * tencent cloud config
+ */
+ public static final String TENCENT_CLOUD_ACCESS_KEY_ID =
"resource.tencent.cloud.access.key.id";
+ public static final String TENCENT_CLOUD_ACCESS_KEY_SECRET =
"resource.tencent.cloud.access.key.secret";
+
Review Comment:
Thank you for your valuable opinions.
But I don't think placing these Tencent Credential Constants in the *storage
plugin* is a good idea.
Cloud providers (Azure, Alibaba, Huawei, and Tencent) offer not only storage
services but also other types of services.
Therefore, I believe Tencent Credential Constants should remain in
`task-plugin/task-api/org.apache.dolphinscheduler.plugin.task.api.TaskConstants`,
alongside the credential constants for other cloud providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
