ruanwenjun commented on code in PR #16544:
URL:
https://github.com/apache/dolphinscheduler/pull/16544#discussion_r1741861957
##########
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ClusterControllerTest.java:
##########
@@ -84,7 +84,7 @@ public void testCreateCluster() throws Exception {
clusterCode = (String) result.getData();
}
- @Test
+ // @Test
Review Comment:
```suggestion
@Test
```
##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowE2ETest.java:
##########
@@ -143,9 +145,9 @@ void testCreateSubWorkflow() {
.goToTab(WorkflowDefinitionTab.class);
workflowDefinitionPage
- .createSubProcessWorkflow()
+ .createSubWorkflowWorkflow()
Review Comment:
```suggestion
.createSubWorkflowTask()
```
##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql:
##########
@@ -126,3 +126,49 @@ CALL drop_column_t_ds_alert_plugin_instance;
DROP PROCEDURE drop_column_t_ds_alert_plugin_instance;
DROP TABLE IF EXISTS `t_ds_trigger_relation`;
+
+-- Rename tables and fields from process to workflow
+ALTER TABLE t_ds_alert change process_definition_code workflow_definition_code
bigint(20);
+ALTER TABLE t_ds_alert change process_instance_id workflow_instance_id int(11);
+
+ALTER TABLE t_ds_command change process_definition_code
workflow_definition_code bigint(20);
+ALTER TABLE t_ds_command change process_instance_priority
workflow_instance_priority int(11);
+ALTER TABLE t_ds_command change process_instance_id workflow_instance_id
int(11);
+ALTER TABLE t_ds_command change process_definition_version
workflow_definition_version int(11);
+
+ALTER TABLE t_ds_error_command change process_definition_code
workflow_definition_code bigint(20);
+ALTER TABLE t_ds_error_command change process_instance_priority
workflow_instance_priority int(11);
+ALTER TABLE t_ds_error_command change process_instance_id workflow_instance_id
int(11);
+ALTER TABLE t_ds_error_command change process_definition_version
workflow_definition_version int(11);
+
+ALTER TABLE t_ds_process_task_relation change process_definition_version
workflow_definition_version int(11);
+ALTER TABLE t_ds_process_task_relation change process_definition_code
workflow_definition_code bigint(20);
+
+ALTER TABLE t_ds_process_task_relation_log change process_definition_version
workflow_definition_version int(11);
+ALTER TABLE t_ds_process_task_relation_log change process_definition_code
workflow_definition_code bigint(20);
+
+ALTER TABLE t_ds_process_instance change process_definition_code
workflow_definition_code bigint(20);
+ALTER TABLE t_ds_process_instance change process_definition_version
workflow_definition_version int(11);
+ALTER TABLE t_ds_process_instance change is_sub_process is_sub_workflow
int(11);
+ALTER TABLE t_ds_process_instance change process_instance_priority
workflow_instance_priority int(11);
Review Comment:
It's better to use procedure to make sure the upgrade is idempotent
##########
.github/workflows/backend.yml:
##########
@@ -133,7 +133,9 @@ jobs:
/bin/bash ${{ matrix.case.script }}
schema-check:
runs-on: ubuntu-latest
- if: ${{ (needs.paths-filter.outputs.db-schema == 'true') ||
(github.event_name == 'push') }}
+ # Temporarily disable schema check until 3.3.0 is released
Review Comment:
It's needed to open the schema check, we should make sure the upgrade from
3.1.9, 3.2.0 can upgrade to 3.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
