zhongjiajie commented on code in PR #16544: URL: https://github.com/apache/dolphinscheduler/pull/16544#discussion_r1743219788
########## .github/workflows/schema-check/postgresql/running-test.sh: ########## @@ -0,0 +1,54 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +set -euox pipefail + +DS_VERSION=$1 +DATABASE_VERSION=$2 + +# Install dev schema +export DATABASE="postgresql" +export SPRING_DATASOURCE_DRIVER_CLASS_NAME="org.postgresql.Driver" +export SPRING_DATASOURCE_USERNAME="postgres" +export SPRING_DATASOURCE_PASSWORD="postgres" +export SPRING_DATASOURCE_URL="jdbc:postgresql://127.0.0.1:5432/dolphinscheduler_dev" +bash ds_schema_check_test/dev/tools/bin/upgrade-schema.sh + +# Install the target version schema and upgrade it +export SPRING_DATASOURCE_URL="jdbc:postgresql://127.0.0.1:5432/dolphinscheduler_${DATABASE_VERSION}" +bash ds_schema_check_test/${DS_VERSION}/tools/bin/upgrade-schema.sh +bash ds_schema_check_test/dev/tools/bin/upgrade-schema.sh + +# Compare the schema Review Comment: Thank you for migrating those into the file :+1: ########## docs/docs/zh/guide/upgrade/upgrade.md: ########## @@ -59,7 +59,7 @@ jar 包 并添加到 `./tools/libs` 目录下，设置以下环境变量 执行结果： -- 原血缘数据迁移至新血缘表 `t_ds_process_task_lineage`。 +- 原血缘数据迁移至新血缘表 `t_ds_workflow_task_lineage`。 Review Comment: Does upgrade.md versionable? or only have single version in our document just like faq.md? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
