fuchanghai commented on code in PR #16565:
URL:
https://github.com/apache/dolphinscheduler/pull/16565#discussion_r1764296023
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java:
##########
@@ -389,6 +389,12 @@ private TaskConstants() {
public static final String HUAWEI_CLOUD_ACCESS_KEY_ID =
"resource.huawei.cloud.access.key.id";
public static final String HUAWEI_CLOUD_ACCESS_KEY_SECRET =
"resource.huawei.cloud.access.key.secret";
+ /**
+ * tencent cloud config
+ */
+ public static final String TENCENT_CLOUD_ACCESS_KEY_ID =
"resource.tencent.cloud.access.key.id";
+ public static final String TENCENT_CLOUD_ACCESS_KEY_SECRET =
"resource.tencent.cloud.access.key.secret";
+
Review Comment:
> Move to storage plugin module
agree with @ruanwenjun ,Although the keys and secrets of various storage
types are currently placed in the task-api module, I think this is unreasonable
and should be placed in their own storage modules or in the storage-api module
WDYT @Mighten cc @SbloodyS @rickchengx
<img width="1426" alt="image"
src="https://github.com/user-attachments/assets/23b51e31-fdd1-4eb2-a82b-6e3c20e16eb4";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
