SbloodyS commented on code in PR #16947:
URL:
https://github.com/apache/dolphinscheduler/pull/16947#discussion_r1926226821
##########
dolphinscheduler-ui/src/components/log-modal/index.tsx:
##########
@@ -153,10 +178,19 @@ export default defineComponent({
icon: isFullscreen
? renderIcon(FullscreenExitOutlined)
: renderIcon(FullscreenOutlined)
+ },
+ {
+ text: autoScrollToBottom
+ ? t('project.task.cancel_log_auto_scroll')
+ : t('project.task.enter_log_auto_scroll'),
+ show: true,
+ action: toggleAutoScroll,
+ icon: renderIcon(ProfileOutlined)
Review Comment:
I think it's better to put this button on the far left because this is the
least commonly used option in most cases.
##########
dolphinscheduler-ui/src/components/log-modal/index.tsx:
##########
@@ -67,8 +71,12 @@ export default defineComponent({
const { t } = useI18n()
const variables = reactive({
- isFullscreen: false
+ isFullscreen: false,
+ autoScrollToBottom: true // New state variable
Review Comment:
If we set to `autoScrollToBottom` to true by default. We should increase
batch query log line num to 100000. This can significantly reduce the number of
requests and improve the user experience.
https://github.com/apache/dolphinscheduler/blob/352b47bd8576a47f83285ecfffec589de462fac0/dolphinscheduler-ui/src/views/projects/task/instance/batch-task.tsx#L128
https://github.com/apache/dolphinscheduler/blob/352b47bd8576a47f83285ecfffec589de462fac0/dolphinscheduler-ui/src/views/projects/task/instance/stream-task.tsx#L115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
