imizao commented on code in PR #16947:
URL:
https://github.com/apache/dolphinscheduler/pull/16947#discussion_r1926422771
##########
dolphinscheduler-ui/src/components/log-modal/index.tsx:
##########
@@ -67,8 +71,12 @@ export default defineComponent({
const { t } = useI18n()
const variables = reactive({
- isFullscreen: false
+ isFullscreen: false,
+ autoScrollToBottom: true // New state variable
Review Comment:
Thanks for the suggestion! In normal cases, a limit of 1000 is sufficient
for most scenarios. The GIF I provided was an exceptional example to
demonstrate the auto-scroll-to-bottom functionality, but it doesn't reflect the
typical usage. Therefore, I believe keeping the limit at 1000 is appropriate
for now. If we encounter performance issues or higher demand in the future, we
can revisit this setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
