Gallardot commented on code in PR #17094: URL: https://github.com/apache/dolphinscheduler/pull/17094#discussion_r2020549115
########## dolphinscheduler-meter/src/main/java/org/apache/dolphinscheduler/meter/MeterAutoConfiguration.java: ########## @@ -42,20 +43,28 @@ */ @Configuration(proxyBeanMethods = false) @EnableAspectJAutoProxy -@ConditionalOnProperty(prefix = "metrics", name = "enabled", havingValue = "true") Review Comment: > Can we remove this config? Then we will enable the metrics in all times. LGTM. Enabling metric is a better practice, but why do users need to turn it off? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
