yingh0ng commented on code in PR #17094: URL: https://github.com/apache/dolphinscheduler/pull/17094#discussion_r2022018723
########## dolphinscheduler-meter/src/main/java/org/apache/dolphinscheduler/meter/MeterAutoConfiguration.java: ########## @@ -42,20 +43,28 @@ */ @Configuration(proxyBeanMethods = false) @EnableAspectJAutoProxy -@ConditionalOnProperty(prefix = "metrics", name = "enabled", havingValue = "true") Review Comment: > Yes, the server heartbeat rely on the metrics provider, so this is must. LGTM. Fix it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
