ruanwenjun commented on issue #17161:
URL: 
https://github.com/apache/dolphinscheduler/issues/17161#issuecomment-2868356210

   Basically LGTM. 
   Right now, in the workflow instance metadata, we are missing the `trigger 
context` of the workflow instance, one workflow instance may be trigger 
multiple times, but we only store the latest once, it's better to add a new 
table t_ds_workflow_instance_action to store these informations.
   
   And for these issue, the problem is the subworkflow instance miss 
`scheduleTime`? IMO, the schedule time should be mandatory, a workflow instance 
should have its own `scheduleTime`、`startTime`、`endTime`. The scheduleTime is 
necessary for dependent or business calculation.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to