reele commented on issue #17161: URL: https://github.com/apache/dolphinscheduler/issues/17161#issuecomment-2888242584
> Basically LGTM. > > Right now, in the workflow instance metadata, we are missing the `trigger context` of the workflow instance, one workflow instance may be trigger multiple times, but we only store the latest once, it's better to add a new table t_ds_workflow_instance_action to store this information. The information should contain action type, action time, action user, action_context(include params). Then we can remove a lot of field in t_ds_workflow_instance. > > And for these issue, the problem is the subworkflow instance miss `scheduleTime`? IMO, the schedule time should be mandatory, a workflow instance/task instance should have its own `scheduleTime`、`startTime`、`endTime`. The scheduleTime is necessary for dependent or business calculation. The subworkflow instance's scheduleTime should be the sub workflow logic task instance's scheduleTime Yes, as : [you mentioned before](https://github.com/apache/dolphinscheduler/pull/16776#pullrequestreview-2417981104). The only issue we need to address here is the performance problem when dependent task query the database. If you think this new approach is acceptable, I'll submit a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
