ruanwenjun commented on code in PR #17606:
URL:
https://github.com/apache/dolphinscheduler/pull/17606#discussion_r2472015296
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowExecutionGraph.java:
##########
@@ -335,7 +336,7 @@ public boolean isAllSuccessorsAreConditionTask(final
ITaskExecutionRunnable task
}
return successors.stream().allMatch(
successor -> isTaskExecutionRunnableSkipped(successor)
- ||
TaskTypeUtils.isConditionTask(taskExecutionRunnable.getTaskInstance().getTaskType()));
+ ||
TaskTypeUtils.isConditionTask(successor.getTaskDefinition().getTaskType()));
Review Comment:
We may need to filter the forbidden susseccors here,
```java
(TaskTypeUtils.isConditionTask(successor.getTaskDefinition().getTaskType())
&& !isTaskExecutionRunnableForbidden(successor))
```
if the successor condition task is forbidden, then should return false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
