Mrhs121 commented on PR #17606: URL: https://github.com/apache/dolphinscheduler/pull/17606#issuecomment-3460908511
> > During the debugging process, I also discovered another problem. The judgment logic in the isTriggerConditionMet method also has the same problem. If the predecessor node that the condition node depends on fails, it will return early, so the condition node will not be triggered > > https://github.com/apache/dolphinscheduler/blob/f4646cef338d81cc21536be0409cd67e42d00d0b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/statemachine/AbstractWorkflowStateAction.java#L72-L82 > > Please use the latest code, I am not sure if this has been fixed by #17601, welcome to add IT case. I checked the code, I found the repair isAllSuccessorsAreConditionTask code just repaired the **triggerTasks potential errors in judgment logic** https://github.com/apache/dolphinscheduler/blob/24e599760f6b6d20d2a9c2c415243bc2f05840f9/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/AbstractTaskStateAction.java#L180-L184 due to isAllSuccessorsAreConditionTask repaired, so failed task will not be marked as a Failure, https://github.com/apache/dolphinscheduler/blob/24e599760f6b6d20d2a9c2c415243bc2f05840f9/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowExecutionGraph.java#L261-L264 so isTaskExecutionRunnableFailed return false. https://github.com/apache/dolphinscheduler/blob/24e599760f6b6d20d2a9c2c415243bc2f05840f9/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowExecutionGraph.java#L206-L217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
