ruanwenjun commented on code in PR #17578:
URL:
https://github.com/apache/dolphinscheduler/pull/17578#discussion_r2494887286
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/subworkflow/SubWorkflowLogicTask.java:
##########
@@ -234,7 +249,7 @@ private SubWorkflowLogicTaskRuntimeContext
triggerNewSubWorkflow() {
.tenantCode(workflowInstance.getTenantCode())
.environmentCode(workflowInstance.getEnvironmentCode())
// todo: transport varpool and local params
- .startParamList(commandParam.getCommandParams())
+
.startParamList(mergeParams(asList(commandParam.getCommandParams(),
globalParamsOfParents)))
Review Comment:
We should merge the current workflow instance's command params, global
params, varpool as the subworkflow instance's command param is enough, we don't
need to find the parant global params here, since the parent global params
should already exist in command params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
