ruanwenjun commented on code in PR #17578:
URL:
https://github.com/apache/dolphinscheduler/pull/17578#discussion_r2498676487
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/subworkflow/SubWorkflowLogicTask.java:
##########
@@ -234,7 +249,7 @@ private SubWorkflowLogicTaskRuntimeContext
triggerNewSubWorkflow() {
.tenantCode(workflowInstance.getTenantCode())
.environmentCode(workflowInstance.getEnvironmentCode())
// todo: transport varpool and local params
- .startParamList(commandParam.getCommandParams())
+
.startParamList(mergeParams(asList(commandParam.getCommandParams(),
globalParamsOfParents)))
Review Comment:
When the code change submits a commit is better, the commit will be polished
when PR merged by committer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
