yangyichao-mango commented on a change in pull request #3188:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3188#discussion_r453149909



##########
File path: 
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistry.java
##########
@@ -137,4 +142,7 @@ private String getLocalAddress(){
 
     }
 
+    public ScheduledExecutorService getHeartBeatExecutor() {
+        return heartBeatExecutor;
+    }

Review comment:
       > It’s a bit redundant here. If it’s just for testing, I don’t think 
it’s necessary.
   
   I agree with @CalvinKirs .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to