tswstarplanet commented on a change in pull request #3188:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3188#discussion_r453212382
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistry.java
##########
@@ -113,6 +110,14 @@ public void stateChanged(CuratorFramework client,
ConnectionState newState) {
public void unRegistry() {
String address = getLocalAddress();
String localNodePath = getMasterPath();
+ heartBeatExecutor.shutdown();
+ try {
+ if
(heartBeatExecutor.awaitTermination(masterConfig.getMasterHeartbeatInterval(),
TimeUnit.SECONDS)) {
+ logger.warn("The heartbeat executor does not shutdown");
+ }
+ } catch (InterruptedException e) {
+ logger.warn("The heartbeat executor is interrupted");
+ }
Review comment:
solved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
