ruanwenjun commented on code in PR #17578:
URL:
https://github.com/apache/dolphinscheduler/pull/17578#discussion_r2502707546
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/subworkflow/SubWorkflowLogicTask.java:
##########
@@ -222,6 +234,11 @@ private SubWorkflowLogicTaskRuntimeContext
triggerNewSubWorkflow() {
final ICommandParam commandParam =
JSONUtils.parseObject(workflowInstance.getCommandParam(),
ICommandParam.class);
+ final List<Property> paramList = mergeParams(asList(
+ commandParam.getCommandParams(),
+ new
ArrayList<>(deserializeVarPool(workflowInstance.getVarPool())),
+ new
ArrayList<>(deserializeVarPool(workflowInstance.getGlobalParams()))));
Review Comment:
The varpool's priority should be highest.
```suggestion
new
ArrayList<>(deserializeVarPool(workflowInstance.getGlobalParams()))),
commandParam.getCommandParams(),
new
ArrayList<>(deserializeVarPool(workflowInstance.getVarPool())));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
