njnu-seafish commented on code in PR #17796:
URL:
https://github.com/apache/dolphinscheduler/pull/17796#discussion_r2641705701
##########
dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/engine/task/dispatcher/WorkerGroupDispatcherTest.java:
##########
@@ -138,4 +156,285 @@ void dispatch_TaskDispatchFails_RetryLogicWorks() throws
TaskDispatchException {
.untilAsserted(() -> verify(taskExecutorClient,
times(2)).dispatch(taskExecutionRunnable));
}
+ @Test
Review Comment:
> You should add UT or IT test case to verify the time out check is enabled.
Your core logic has not been tested.
OK. I need to modify the master's configuration. I'll submit the changes and
test them — I can't run the integration tests locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
