njnu-seafish commented on code in PR #17796:
URL:
https://github.com/apache/dolphinscheduler/pull/17796#discussion_r2684645579
##########
dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/engine/task/dispatcher/WorkerGroupDispatcherTest.java:
##########
@@ -46,7 +47,8 @@ class WorkerGroupDispatcherTest {
@BeforeEach
void setUp() {
taskExecutorClient = mock(ITaskExecutorClient.class);
- dispatcher = new WorkerGroupDispatcher("TestGroup",
taskExecutorClient);
+ final MasterConfig masterConfig = new MasterConfig();
+ dispatcher = new WorkerGroupDispatcher("TestGroup",
taskExecutorClient, masterConfig.getDispatchTimeout());
Review Comment:
> You should add a validated test case.
The following integration test produces an unexpected result because the
LogicFakeTask type runs on the Master and does not involve WorkerGroup
dispatching.
I track the fix in a separate issue:
https://github.com/apache/dolphinscheduler/issues/17872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
