SbloodyS commented on code in PR #17818:
URL:
https://github.com/apache/dolphinscheduler/pull/17818#discussion_r2644654833
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/WorkflowAlertManager.java:
##########
@@ -260,8 +264,8 @@ public boolean isNeedToSendWarning(WorkflowInstance
workflowInstance) {
}
public void sendTaskTimeoutAlert(WorkflowInstance workflowInstance,
- TaskInstance taskInstance,
- ProjectUser projectUser) {
+ TaskInstance taskInstance) {
+ ProjectUser projectUser =
projectMapper.queryProjectWithUserByWorkflowInstanceId(workflowInstance.getId());
Review Comment:
It's better to use `ProjectDao` instead of directly use `ProjectMapper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
