ruanwenjun commented on code in PR #17818:
URL:
https://github.com/apache/dolphinscheduler/pull/17818#discussion_r2644657542
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java:
##########
@@ -244,6 +244,13 @@ private void saveTaskTimeoutAlert(Alert alert, String
content, int alertGroupId)
public void sendTaskTimeoutAlert(WorkflowInstance workflowInstance,
TaskInstance taskInstance,
ProjectUser projectUser) {
+ assert projectUser != null;
Review Comment:
Only a few historical codes contain assert statements.
The proper fix is to set the property to empty, rather than ignore the alert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
