njnu-seafish commented on code in PR #17819:
URL:
https://github.com/apache/dolphinscheduler/pull/17819#discussion_r2675216549
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java:
##########
Review Comment:
In our environment, we've already resolved the task timeout alerts and
workflow timeout alerts. Here's how I determine whether a workflow has
completed:
final IWorkflowExecutionGraph workflowExecutionGraph =
workflowExecutionRunnable.getWorkflowExecutionGraph();
if (workflowExecutionGraph.isAllTaskExecutionRunnableChainFinish()) {
// all the TaskExecutionRunnable chain in the graph is finish,
means the workflow is already finished.
return;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
