njnu-seafish commented on code in PR #17819: URL: https://github.com/apache/dolphinscheduler/pull/17819#discussion_r2688720148
########## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java: ########## Review Comment: > `isFinalState()` reflects the persistent final state, making it more reliable. `isAllTaskExecutionRunnableChainFinish()`, on the other hand, only reflects the task completion state in memory; it may not yet have transitioned to the final workflow state. In my opinion, If the workflow is already in a completed state in memory, does that mean timeout handling is no longer meaningful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
