njnu-seafish commented on code in PR #18086:
URL:
https://github.com/apache/dolphinscheduler/pull/18086#discussion_r2958670726
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java:
##########
@@ -211,8 +211,7 @@ public Result<Object>
queryDataSourceListPaging(@Parameter(hidden = true) @Reque
@PostMapping(value = "/connect")
@ResponseStatus(HttpStatus.OK)
@ApiException(CONNECT_DATASOURCE_FAILURE)
- public Result<Boolean> connectDataSource(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
-
@io.swagger.v3.oas.annotations.parameters.RequestBody(description =
"dataSourceParam") @RequestBody String jsonStr) {
+ public Result<Boolean>
connectDataSource(@io.swagger.v3.oas.annotations.parameters.RequestBody(description
= "dataSourceParam") @RequestBody String jsonStr) {
Review Comment:
> Why change this?
This issue is related to user authentication and will be addressed in a
separate PR. Per the senior developer's suggestion, I will split these two
types of issues into distinct Issues and PRs.
please review this:
https://github.com/apache/dolphinscheduler/pull/18073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
