njnu-seafish commented on code in PR #18086:
URL:
https://github.com/apache/dolphinscheduler/pull/18086#discussion_r3015135044
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java:
##########
@@ -211,8 +211,7 @@ public Result<Object>
queryDataSourceListPaging(@Parameter(hidden = true) @Reque
@PostMapping(value = "/connect")
@ResponseStatus(HttpStatus.OK)
@ApiException(CONNECT_DATASOURCE_FAILURE)
- public Result<Boolean> connectDataSource(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
-
@io.swagger.v3.oas.annotations.parameters.RequestBody(description =
"dataSourceParam") @RequestBody String jsonStr) {
+ public Result<Boolean>
connectDataSource(@io.swagger.v3.oas.annotations.parameters.RequestBody(description
= "dataSourceParam") @RequestBody String jsonStr) {
Review Comment:
> I didn't find any related comments in this PR #18073, please elaborate it.
1. Refactoring, such as adding comments, should be handled in a separate PR.
<img width="1024" height="1122" alt="企业微信截图_17749546132839"
src="https://github.com/user-attachments/assets/ba60e943-ecd3-4398-adc9-7e46dcc90964";
/>
2. The loginUser variable is unused in the connectDataSource implementation,
so it should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
