norrishuang commented on PR #18069: URL: https://github.com/apache/dolphinscheduler/pull/18069#issuecomment-4198898735
Hi @SbloodyS, thank you for the detailed review! I've addressed all the feedback in the latest commit: 1. **`UpperCamelCaseStrategy` deprecated** — Replaced with `PropertyNamingStrategies.UPPER_CAMEL_CASE` (Jackson 2.12+ API) 2. **Remove `@since dev-SNAPSHOT`** — Removed the javadoc tag 3. **Redundant `applicationId` field** — Removed the field; now reading directly from `emrServerlessParameters.getApplicationId()` throughout 4. **Store `jobRunId` directly** — Changed `setAppIds()` to store only `jobRunId` (applicationId is always available from parameters). Updated failover recovery accordingly: `jobRunId = getAppIds()` 5. **SonarCloud `ObjectMapper.configure` warning** — Already using `JsonMapper.builder().configure(...)` (the non-deprecated builder API); no `ObjectMapper.configure(Feature, boolean)` calls exist 6. **Empty suggestion on line 73** — Removed the `@since dev-SNAPSHOT` tag as suggested All 15 unit tests pass. Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
