norrishuang commented on PR #18069: URL: https://github.com/apache/dolphinscheduler/pull/18069#issuecomment-4209853727
Hi @SbloodyS, I've addressed all the remaining review comments. Replaced hardcoded state strings with `JobRunState` enum constants throughout (`WAITING_STATES`, `mapStateToExitCode()`, and unit tests). Could you take another look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
