ruanwenjun opened a new pull request, #18225: URL: https://github.com/apache/dolphinscheduler/pull/18225
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! --> ## Was this PR generated or assisted by AI? YES, ops 4.7 ## Purpose of the pull request related issue #18224 ## Brief change log Refactor 5 EnvironmentService methods from Map<String, Object> to typed return / void + ServiceException, with cascading updates to the controller, PythonGateway and unit test: - verifyEnvironment(String): void - queryEnvironmentByName(String): EnvironmentDto - queryEnvironmentByCode(Long): EnvironmentDto - queryAllEnvironmentList(User): List<EnvironmentDto> - deleteEnvironmentByCode(User, Long): void HTTP wire format is preserved: ApiExceptionHandler converts ServiceException to the same Result(code, msg) shape that BaseController.returnDataList(map) produced; success paths use Result.success(data) matching the prior JSON body byte-for-byte. EnvironmentControllerTest is unchanged on purpose. Py4J boundary is preserved: PythonGateway.getEnvironmentInfo continues to throw IllegalArgumentException with the same message format on lookup failure, so Python SDK clients see no behavior change. This is the first migration in the series tracked by #18224; the remaining services in dolphinscheduler-api will follow using the same template, after which BaseService.putMsg(Map) and BaseController.returnDataList(Map) can be removed. ## Verify this pull request <!--*(Please pick either of the following options)*--> This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: <!--*(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* --> (or) ## Pull Request Notice [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
