ruanwenjun commented on code in PR #18225:
URL:
https://github.com/apache/dolphinscheduler/pull/18225#discussion_r3212164314
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/EnvironmentController.java:
##########
@@ -136,11 +136,10 @@
@GetMapping(value = "/query-by-code")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_ENVIRONMENT_BY_CODE_ERROR)
- public Result queryEnvironmentByCode(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
- @RequestParam("environmentCode") Long
environmentCode) {
-
- Map<String, Object> result =
environmentService.queryEnvironmentByCode(environmentCode);
- return returnDataList(result);
+ public Result<EnvironmentDto> queryEnvironmentByCode(@Parameter(hidden =
true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
Review Comment:
ignore, will remove the loginUser at another PR, we should use ThreadLocal
to hold this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
