ruanwenjun opened a new pull request, #18253: URL: https://github.com/apache/dolphinscheduler/pull/18253
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! --> ## Was this PR generated or assisted by AI? YES, ops 4.7 ## Purpose of the pull request Tracking issue: #18249 Expose every UserMapper method the api layer needs on UserDao (queryAllGeneralUser, queryByUserNameAccurately, queryUserByNamePassword, queryUserPaging, queryDetailsById, queryUserListByAlertGroupId, queryUserListByTenant, queryTenantCodeByUserId, queryUserByToken, queryUserListByQueue, existUser, updateUserQueue, queryAuthedUserListByProjectId, queryEnabledUsers, queryUserWithWorkflowDefinitionCode) and replace every direct UserMapper reference in dolphinscheduler-api with the Dao, so Mapper usage stays inside dolphinscheduler-dao.repository as documented in dolphinscheduler-dao/CLAUDE.md. Notes: - BaseDao#updateById and BaseDao#deleteById return boolean (Mapper returned int); affected call sites in UsersServiceImpl (updateUser, deleteUserById, updateUserByUserName) were refactored to use the boolean directly. Test mocks switched thenReturn(1/0) to thenReturn(true/false). - selectById / selectByIds / selectList(null) were replaced with their IDao equivalents queryById / queryByIds / queryAll. - LoginHandlerInterceptorTest's @MockBean(name = "userMapper") was updated to @MockBean(name = "userDao") so Spring resolves the renamed field. UserMapper-look-alikes (ProjectUserMapper, DataSourceUserMapper, K8sNamespaceUserMapper) are out of scope for this commit and were deliberately left untouched. No production behavior changes; the Mapper interface itself is untouched. ## Brief change log <!--*(for example:)* - *Add maven-checkstyle-plugin to root pom.xml* --> ## Verify this pull request <!--*(Please pick either of the following options)*--> This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: <!--*(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* --> (or) ## Pull Request Notice [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
