ruanwenjun opened a new pull request, #18259:
URL: https://github.com/apache/dolphinscheduler/pull/18259
<!--Thanks very much for contributing to Apache DolphinScheduler, we are
happy that you want to help us improve DolphinScheduler! -->
## Was this PR generated or assisted by AI?
YES, gpt 5.5
## Purpose of the pull request
Introduce DataSourceDao and DataSourceUserDao so the api layer depends only
on the repository abstraction. The two mappers are bundled because
DataSourceServiceImpl and UsersServiceImpl share both.
DataSourceDao renames mapper.selectPaging / selectPagingByIds to
queryDataSourcePaging / queryDataSourcePagingByIds and folds the
selectByMap("user_id", X) idiom from DataSourceServiceImpl into
queryByUserId(int) so the QueryWrapper-style call no longer leaks into the api
layer.
DataSourceUserDao exposes deleteByUserId / deleteByDatasourceId as void (the
mapper-returned row count was never consulted at the call sites).
Tracking issue: #18249
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please
describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to
`docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
