leocook commented on issue #18267: URL: https://github.com/apache/dolphinscheduler/issues/18267#issuecomment-4465310612
Hi, I did some quick research on how other popular projects handle S3-compatible storage (like MinIO), hope it helps: - **Hadoop S3A** — same connector, custom endpoint + any region string, no enum validation - **Trino** — same connector, `s3.endpoint` + `s3.region` accepts any value - **Flink / Spark / Airflow / GitLab** — all same approach, just add endpoint config **None of them create a separate plugin for this.** Because MinIO is basically S3 protocol with a different endpoint, not really a different storage type. I understand the concern about future compatibility issues, but personally I feel creating a new plugin may introduce near-duplicate code and user confusion (should I choose S3 or S3-Compatible?). The fix itself is quite small — just skip `Regions.fromName()` when custom endpoint is configured, probably less than 10 lines. Of course this is just my thought, happy to hear other opinions. And happy to help if needed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
