ruanwenjun commented on issue #18267: URL: https://github.com/apache/dolphinscheduler/issues/18267#issuecomment-4477544059
As for the issue of duplicate code, I don’t think we need to worry about it, because Mino can reduce duplicate code by importing the current S3 plugin module. Of course, this raises a question of scope: specifically, whether Mino includes all of S3’s features. If you’re certain that this is the only difference in Mino’s use of S3, I agree that we should handle it by adding an `if` statement, but we need to clearly explain this in the comments. Many projects end up with messy code precisely because of this kind of haphazard addition of `if` statements for compatibility purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
