JinRudy commented on PR #18315: URL: https://github.com/apache/dolphinscheduler/pull/18315#issuecomment-4658060582
Hi @SbloodyS, thanks for the follow-up. I added `SeatunnelEngineTaskTest` covering the engine `buildOptions` path: - `buildOptionsUsesMasterForDeployMode` — asserts `--master cluster` is emitted when `deployMode` is set, exercising the changed line. - `buildOptionsOmitsMasterWhenDeployModeMissing` — guards the existing null-deploy-mode behavior. - `buildOptionsAppendsOthersWhenPresent` — covers the existing `others` argument path together with the new flag. I also rebased the branch onto the latest `dev` so the PR is no longer behind the base branch. Local verification: ``` ./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel -am test -Dtest=SeatunnelEngineTaskTest # Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 ./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel spotless:apply ``` Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
