JinRudy commented on code in PR #18315:
URL:
https://github.com/apache/dolphinscheduler/pull/18315#discussion_r3407536495
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/self/SeatunnelEngineTask.java:
##########
@@ -46,7 +46,7 @@ public void init() {
public List<String> buildOptions() throws Exception {
List<String> args = super.buildOptions();
if (!Objects.isNull(seatunnelParameters.getDeployMode())) {
- args.add(Constants.DEPLOY_MODE_OPTIONS);
Review Comment:
Updated in the latest push: `Constants.DEPLOY_MODE_OPTIONS` is removed, and
the engine path is covered by `SeatunnelEngineTaskTest`.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/spark/SeatunnelSparkTask.java:
##########
@@ -51,7 +50,7 @@ public void init() {
@Override
public List<String> buildOptions() throws Exception {
List<String> args = super.buildOptions();
- args.add(DEPLOY_MODE_OPTIONS);
+ args.add("--deploy-mode");
Review Comment:
Added the engine `buildOptions` tests and reran the Seatunnel module checks
locally.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/self/SeatunnelEngineTask.java:
##########
@@ -46,7 +46,7 @@ public void init() {
public List<String> buildOptions() throws Exception {
List<String> args = super.buildOptions();
if (!Objects.isNull(seatunnelParameters.getDeployMode())) {
- args.add(Constants.DEPLOY_MODE_OPTIONS);
Review Comment:
Updated in the latest push: `Constants.DEPLOY_MODE_OPTIONS` is removed, and
the engine path is covered by `SeatunnelEngineTaskTest`.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/spark/SeatunnelSparkTask.java:
##########
@@ -51,7 +50,7 @@ public void init() {
@Override
public List<String> buildOptions() throws Exception {
List<String> args = super.buildOptions();
- args.add(DEPLOY_MODE_OPTIONS);
+ args.add("--deploy-mode");
Review Comment:
Added the engine `buildOptions` tests and reran the Seatunnel module checks
locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
