qiuyanjun888 commented on issue #18311: URL: https://github.com/apache/dolphinscheduler/issues/18311#issuecomment-4765121462
Hi @ruanwenjun @SbloodyS, thanks for your feedback on my previous design proposal: https://github.com/apache/dolphinscheduler/issues/18311#issuecomment-4739634666. I have implemented the code based on that design direction and opened PR #18367: https://github.com/apache/dolphinscheduler/pull/18367. The PR uses a local shell task process-group approach, with configuration support, to make task cancellation kill the whole shell task process group more reliably. It also includes tests and related documentation/configuration updates. Could you please take a look when you have time and advise whether this direction is acceptable, especially regarding the process-group/`setsid` concern discussed above? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
