matthewwalker1621-star commented on issue #18311: URL: https://github.com/apache/dolphinscheduler/issues/18311#issuecomment-4767036515
Regarding the proposed redesign and the implementation in PR #18367, I have a few thoughts following the recent discussion. While using setsid to manage process groups is a straightforward way to prevent orphaned processes, we should address the concerns raised about potential orphan-process issues introduced by the extra fork and the system load spikes observed when frequently creating systemd units at high concurrency. Since PR #18312 already addresses the immediate bug involving misclassified liveness detection and the READY_STOP hang, I suggest we evaluate that fix first. For the broader goal of a robust task process boundary, we might want to further explore the native helper approach—similar to Airflow—to achieve setpgid(0, 0) without the downsides of an extra fork. On Mon, Jun 22, 2026, 12:13 AM Yanjun Qiu ***@***.***> wrote: > *qiuyanjun888* left a comment (apache/dolphinscheduler#18311) > <https://github.com/apache/dolphinscheduler/issues/18311#issuecomment-4765121462> > > Hi @ruanwenjun <https://github.com/ruanwenjun> @SbloodyS > <https://github.com/SbloodyS>, thanks for your feedback on my previous > design proposal: #18311 (comment) > <https://github.com/apache/dolphinscheduler/issues/18311#issuecomment-4739634666> > . > > I have implemented the code based on that design direction and opened PR > #18367 <https://github.com/apache/dolphinscheduler/pull/18367>: #18367 > <https://github.com/apache/dolphinscheduler/pull/18367>. > > The PR uses a local shell task process-group approach, with configuration > support, to make task cancellation kill the whole shell task process group > more reliably. It also includes tests and related > documentation/configuration updates. > > Could you please take a look when you have time and advise whether this > direction is acceptable, especially regarding the process-group/setsid > concern discussed above? Thanks. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/dolphinscheduler/issues/18311?email_source=notifications&email_token=B7GHLXE5A6TN2IWP4MM5FBD5BC6BNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZWGUYTEMJUGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-4765121462>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/B7GHLXHWBROPKXRTQJJ72CT5BC6BNAVCNFSNUABFKJSXA33TNF2G64TZHMYTOMZTGM2TOMBWHNEXG43VMU5TINJWG4YTMNRWG43KC5QC> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/B7GHLXB5LLBVMGHRYYFJ2BD5BC6BNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZWGUYTEMJUGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> > and Android > <https://github.com/notifications/mobile/android/B7GHLXDACMNYDLX2L4YWLLT5BC6BNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZWGUYTEMJUGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. > Download it today! > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
