shangeyao opened a new pull request, #18385: URL: https://github.com/apache/dolphinscheduler/pull/18385
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! --> ## Was this PR generated or assisted by AI? YES. Use AI to implement the DAG validation logic and unit tests, then verify locally with Maven. ## Purpose of the pull request close #17057 ## Brief change log - Add Kahn topological sort validation in `WorkflowGraph` constructor on the master server - Throw `IllegalArgumentException` when workflow task relations contain a cycle - Add `WorkflowGraphCheckIfDAGTest` covering single task, valid DAG, and cyclic graph cases ## Verify this pull request This change added tests and can be verified as follows: - Added `WorkflowGraphCheckIfDAGTest` to verify DAG validation in `WorkflowGraph` constructor - Ran `./mvnw -pl dolphinscheduler-master -am test -Dtest=WorkflowGraphCheckIfDAGTest -Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true` ## Pull Request Notice [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md` Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
