shangeyao commented on PR #18385: URL: https://github.com/apache/dolphinscheduler/pull/18385#issuecomment-4850385388
Thanks for the review, @ruanwenjun. On complexity: `checkIfDAG()` is a standard Kahn topological sort (~50 lines), with no new edge-case rules — it reuses the same edge filter already used in `addTaskEdge()`. The rest of the constructor is unchanged. Happy to extract it into a small utility class if that would be easier to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
