ruanwenjun commented on code in PR #18645:
URL:
https://github.com/apache/dolphinscheduler/pull/18645#discussion_r4024251135
##########
dolphinscheduler-registry/dolphinscheduler-registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/ha/AbstractHAServer.java:
##########
@@ -39,7 +40,11 @@ public abstract class AbstractHAServer implements HAServer {
private final String serverIdentify;
- private ServerStatus serverStatus;
+ private final String electionIdentity;
+
+ private volatile ServerStatus serverStatus;
+
+ private volatile boolean closed;
Review Comment:
Ned to add new enum ServerStatus, need at least contains started, closed。
But I don't think this PR needs to modify this. Are there currently any
multithreaded operations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
