michaellx1057 commented on code in PR #18645:
URL:
https://github.com/apache/dolphinscheduler/pull/18645#discussion_r4024531580
##########
dolphinscheduler-registry/dolphinscheduler-registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/ha/AbstractHAServer.java:
##########
@@ -51,24 +56,23 @@ public AbstractHAServer(final Registry registry, final
String selectorPath, fina
this.registry = registry;
this.selectorPath = checkNotNull(selectorPath);
this.serverIdentify = checkNotNull(serverIdentify);
Review Comment:
Thanks for the suggestion. I originally used a UUID to avoid relying on
different construction timestamps for instances at the same address. For normal
process restarts, I agree that a millisecond timestamp is a reasonable
simplification here.
Updated in a62e99f to use `serverIdentify` directly with
`System.currentTimeMillis()`, removing the extra field and UUID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
